Skip to content

fix: ack.sh exits 0 with message when session already complete#13

Merged
tupe12334 merged 1 commit into
mainfrom
fix/idempotent-ack
Jun 11, 2026
Merged

fix: ack.sh exits 0 with message when session already complete#13
tupe12334 merged 1 commit into
mainfrom
fix/idempotent-ack

Conversation

@tupe12334

Copy link
Copy Markdown
Member

Summary

  • ack.sh previously errored with "invalid next state ''" when run after a session was already complete (current_state = "[*]")
  • Architecture.md specifies the correct behavior: exit 0 with steplock: nothing to acknowledge for '<checklist>' (session already complete)
  • Added check at the top of ack.sh: if current_state == "[*]", print the message and exit 0
  • Added ack_sh_handles_complete_session test in scripts.rs verifying the embedded script contains the idempotent guard

Test plan

  • cargo test passes
  • Running ack.sh on a complete session prints "session already complete" and exits 0
  • Running ack.sh on an active session still works correctly

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@tupe12334 tupe12334 marked this pull request as ready for review June 11, 2026 20:00
@tupe12334 tupe12334 merged commit 9166946 into main Jun 11, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant